fix: calldata encoding fails for tuple params #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit 028d808. ♻️ This comment has been updated with latest results. |
Unit Test Results 4 files 264 suites 11m 35s ⏱️ Results for commit 028d808. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR: |
vasyl-ivanchuk
force-pushed
the
kiriyaga-txfusion-tuple-array-input-data
branch
from
b63695d to
028d808
Compare
|
@kiriyaga-txfusion please, configure GitHub signed commits. PRs with at least one unsigned commit cannot be merged. I squashed all commits in this PR into a single signed commit to merge the changes. |
vasyl-ivanchuk
requested review from
vasyl-ivanchuk
and removed request for
Romsters
vasyl-ivanchuk
approved these changes
Jan 21, 2025
|
🎉 This PR is included in version 2.60.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR implements support for encoding non-primitive input types. With this update, all input data, including tuples, arrays, and combinations of various types, will be correctly encoded.
Why ❔
In the current version of the block explorer, users encounter an error when input data includes complex objects or arrays.
For show we will use: https://explorer.zksync.io/tx/0xe39dbc98b41bb22620b78e3a3848ab34982310f9564f27d1e809cfdd461fa54e
Example without fix:
Example with fix:
fixes #321
Checklist